mkdumprd: basic support for btrfs subvol #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licliu
force-pushed
the
btrfs_support
branch
2 times, most recently
from
001e85c to
c4e7656
Compare
Member
|
Hi @licliu , It seems this PR is ready for review though it's marked as draft, am I correct? |
Collaborator
Author
|
Hi @coiby, I used an AI tool locally to review this PR and found some issues, I'll post a new version after I fix them. |
Member
I see. Looking forward to your new version! |
Collaborator
Author
|
rebased by the wrong way. I apologize for the disruption. |
The kdump scripts previously could not correctly handle cases where the
dump target was located on a btrfs subvolume. The logic for finding
the mount point did not account for the way subvolumes are represented,
leading to failures in identifying the target device and checking for
available space.
This patch introduces support for btrfs subvolumes by:
1. Adding a new helper function `get_btrfs_subvol_from_mntopt` to
extract the subvolume name from mount options.
2. Modifying `get_mntpoint_from_target` to accept a subvolume
name. When a subvolume is provided, it correctly identifies the
mount point by looking for the source entry that includes the
subvolume name (e.g., `/dev/sda1[/subvol]`).
3. Updating various functions in `mkdumprd`, `kdump-lib.sh`, and the
dracut module setup scripts to detect if the target is on a btrfs
filesystem, parse the subvolume, and pass it to the relevant
functions for mount point resolution and free space checks.
This ensures that kdump can now be reliably configured with a dump
target located on a btrfs subvolume.
Signed-off-by: Lichen Liu <[email protected]>
Add test cases to verify new and modified logic for handling btrfs subvolumes as kdump targets. Assisted-by: Claude (Anthropic) Signed-off-by: Lichen Liu <[email protected]>
Collaborator
Author
|
Hi @coiby, I pushed a new verison with the help of AI, and I marked it as ready to review, thanks for your attention! |
coiby
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kdump scripts previously could not correctly handle cases where the dump target was located on a btrfs subvolume. The logic for finding the mount point did not account for the way subvolumes are represented, leading to failures in identifying the target device and checking for available space.
This patch introduces support for btrfs subvolumes by:
get_btrfs_subvol_from_mntoptto extract the subvolume name from mount options.get_mntpoint_from_targetto accept a subvolume name. When a subvolume is provided, it correctly identifies the mount point by looking for the source entry that includes the subvolume name (e.g.,/dev/sda1[/subvol]).mkdumprd,kdump-lib.sh, and the dracut module setup scripts to detect if the target is on a btrfs filesystem, parse the subvolume, and pass it to the relevant functions for mount point resolution and free space checks.This ensures that kdump can now be reliably configured with a dump target located on a btrfs subvolume.